Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change MATLAB license file mounting #149

Merged
merged 3 commits into from
May 15, 2024

Conversation

johnstairs
Copy link
Member

@johnstairs johnstairs commented May 8, 2024

Proposing small changes to the way we make a MATLAB license available to the devcontainer. Instead of bind mounting the file directly, we bind mount to a temporary location so that the license file can be updated in the devcontainer without affecting the host.

@johnstairs johnstairs requested a review from naegelejd May 8, 2024 15:40
Copy link
Contributor

@naegelejd naegelejd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed fixes:

  • Create the license dir
  • sudo to copy file into the dir

@naegelejd naegelejd merged commit 0b74fc9 into naegelejd/matlab May 15, 2024
2 checks passed
@naegelejd naegelejd deleted the johnstairs/matlab-license-tunnel branch May 15, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants