Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default value for aliased generic types #83

Merged
merged 2 commits into from
Oct 20, 2023
Merged

Fix default value for aliased generic types #83

merged 2 commits into from
Oct 20, 2023

Conversation

naegelejd
Copy link
Contributor

Addresses #82

@johnstairs
Copy link
Member

The fix looks good. The types you added to the model don't seem to really show the issue thoughm unless I'm missing something.

@johnstairs
Copy link
Member

Thanks @naegelejd! Please squash when you merge this.

@naegelejd naegelejd merged commit b9d8ab5 into main Oct 20, 2023
14 checks passed
@naegelejd naegelejd deleted the naegelejd/aliased-generics branch October 20, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstairs johnstairs johnstairs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@naegelejd @johnstairs