Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generation on /beta endpoint doesn't work #93

Closed
christophwille opened this issue Jul 19, 2017 · 8 comments
Closed

Generation on /beta endpoint doesn't work #93

christophwille opened this issue Jul 19, 2017 · 8 comments

Comments

@christophwille
Copy link

christophwille commented Jul 19, 2017

Previous issue #89 dated 5/23

It still crashes on the /beta endpoint. How am I supposed to build me a custom Microsoft.Graph for the /beta endpoint if the prerequisite is not up to the job? Nobody else trying to build that?
AB#7097

caitlinrussell pushed a commit that referenced this issue Jul 19, 2017
This unblocks #93 for generating libraries against beta
@caitlinrussell
Copy link

caitlinrussell commented Jul 19, 2017

This issue is actually the result of several other issues:

  1. The Graph API metadata has bugs
    a. We work with teams internally to help promote a valid metadata to v1.0 but are looking to do this earlier so that beta is also available for generation
  2. The generator does not recover from errors
    a. I am currently working on this. You can build beta successfully on the cbales-working branch if you’d like to try this method. However, although it recovers from errors, the resulting generated files will contain errors reflected from the metadata.
  3. VIPR does not handle capability annotation inheritance correctly
    a. Therefore, in the meantime, we strip out all capability annotations from our metadata
    b. While you will not see any generator or build errors, the resulting library will having missing functionality if you include the annotations
  4. We add custom edits to the metadata that are not currently documented
    a. In the short-term, I will add documentation on these metadata workarounds
    b. Long-term, we need to develop a programmatic strategy for handling these custom edits

To unblock you, I have uploaded a valid beta metadata document that will allow you to generate against it.

2123574

@christophwille
Copy link
Author

Thanks for the metadata file (works), and also thanks for documenting the necessary manual fixes.
Color me surprised though that the Graph teams themselves are not using vipr as a BVT for their most recent changes on /beta.
Would it be possible to have an automated package generation (eg for myget publication) that combines the /dev branch from the SDK plus the /beta endpoint from Graph? (breaks and malfunctions would be ok) This would help early adopters enormously.

@tonipohl
Copy link

Agree, a working SDK for the Beta endpoint would definitely help. Thx!

@caitlinrussell
Copy link

Great feedback. We are currently working on the automation pipeline that will make this a trivial addition. I will keep your feedback in mind as we continue the conversation about adding beta SDK packages.

@dan-silver dan-silver changed the title Generation on /beta endpoint still crashes (commit 112e30c652ba9ccd2b3dc0073b5291460f37992b) Generation on /beta endpoint doesn't work Aug 21, 2017
@christophwille
Copy link
Author

Any news on the automation pipeline for the beta endpoint / beta SDK?

@turowicz
Copy link

Any updates on this? @MIchaelMainer @Cbales

@deepak2016
Copy link
Contributor

@turowicz we are actively working on this work item and will update here once we publish SDK for beta endpoint.

@ddyett ddyett added the promote label Jan 11, 2021
@zengin
Copy link
Contributor

zengin commented Aug 6, 2022

this is a stale issue, closing...

@zengin zengin closed this as completed Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants