Fix: responsive pivot items #460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, it would help to have tips on each taab on small screens now that the tab names have been replaced by icons. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
On smaller screens, the view of the components (request/response) is altered.
Fixes #450
Demo
Desktop:
Mobile:
Notes
There is currently an open issue on the fluent ui repository to help users sort this out. Hence scrolling horizontally or having a behaviour similar to an overflowing command bar is not feasible at the moment.
This current implementation utilises an easier idea that the user will have interacted with the desktop version of GE before going mobile and so the icons will make things easier to find and remember.
Testing Instructions