Merge pull request #1220 from nbusser/main

refactor(ws-response): mutability on response
middyjs · Jun 30, 2024 · 9c55c3f · 9c55c3f
2 parents e862f8d + 9af571b
commit 9c55c3f
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/packages/ws-response/index.js b/packages/ws-response/index.js
@@ -27,10 +27,9 @@ const wsResponseMiddleware = (opts) => {
   }
 
   const wsResponseMiddlewareAfter = async (request) => {
-    normalizeWsResponse(request)
-    const { response } = request
+    const normalizedResponse = normalizeWsResponse(request)
 
-    if (!response.ConnectionId) return
+    if (!normalizedResponse.ConnectionId) return
 
     if (!options.awsClientOptions.endpoint && request.event.requestContext) {
       options.awsClientOptions.endpoint =
@@ -43,7 +42,7 @@ const wsResponseMiddleware = (opts) => {
       client = await createClient(options, request)
     }
 
-    const command = new PostToConnectionCommand(response)
+    const command = new PostToConnectionCommand(normalizedResponse)
     await client
       .send(command)
       .catch((e) => catchInvalidSignatureException(e, client, command))
@@ -68,7 +67,6 @@ const normalizeWsResponse = (request) => {
     response = { Data: response }
   }
   response.ConnectionId ??= request.event.requestContext?.connectionId
-  request.response = response
   return response
 }