fix(typescript): ssm context is enriched correctly #1089
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmammino
force-pushed
the
get-internal-type-safety
branch
from
cdc06a5
to
f42fe50
Compare
|
See my WIP PR with basic implementation: #1093 |
|
Closing in favour of #1093 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1084
@m-radzikowski, I have a first draft for a potential solution to what you suggested in #1084. I am not sure I understood your point about JsonValue.I'd love if you can give this a quick review and let me know if this is going in the right direction.On a second look at what I originally did in this PR, I understood that what I did was only testing the current existing solution for
ssm. 😓Now I think I understand that your suggestion is to generalise that approach to something that would work for all the other middleware that change the context. Is that correct?
With that being said, there's a bit of TS magic here that I am not entirely comfortable with... Can you, please, expand a bit on your pseudo-code maybe providing something more concrete that I can work with?
Thanks