Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(http-error-handler): non http errors will always be handled #1117

Merged
merged 2 commits into from
Nov 8, 2023
Merged

fix(http-error-handler): non http errors will always be handled #1117

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
504c482
fix(http-error-handler): non http errors will be handled as 'Internal…
qoomon Oct 27, 2023
4c99241
fix: extra )
willfarrell Nov 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions packages/http-error-handler/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,10 @@
}

// Non-http error OR expose set to false
if (
options.fallbackMessage &&
(!request.error.statusCode || !request.error.expose)
) {
if (!request.error.expose || !request.error.statusCode)) {
Fixed Show fixed Hide fixed
request.error = {
statusCode: 500,
message: options.fallbackMessage,
message: options.fallbackMessage || 'Internal Server Error',
expose: true
}
}
Expand Down
Loading