🏷️ ensures that handler return is properly typed #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This change addresses an issue where the return type of handlers was not being correctly enforced by the TypeScript compiler. As far as I could tell, the issue is caused by the `infer` keyword not working with generic types. - Added `TResult` as a type parameter to `MiddlewareHandler` to explicitly specify the handler's return type. - Modified the `middy` function signature to pass `TResult` to `MiddlewareHandler`. - By explicitly specifying `TResult`, we ensure that the compiler can correctly enforce the handler's return type. closes middyjs#1228
canassa
force-pushed
the
fix-handler-return-type
branch
from
2e6ccd4
to
dfe5aaf
Compare
|
Thanks for the PR! |
|
@willfarrell Thanks! Do you know if this will be included in a release soon? or only after 6.X? |
|
It's in release 5.5.1 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
inferkeyword not working with generic types.TResultas a type parameter toMiddlewareHandlerto explicitly specify the handler's return type.middyfunction signature to passTResulttoMiddlewareHandler.TResult, we ensure that the compiler can correctly enforce the handler's return type.closes #1228