Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/types/remove-aws-xray-sdk-deps #749

Merged
merged 1 commit into from
Dec 20, 2021
Merged

feat/types/remove-aws-xray-sdk-deps #749

merged 1 commit into from
Dec 20, 2021

Commits on Nov 15, 2021

  1. feat/types/remove-aws-xray-sdk-deps 

    In several plugin definitions `aws-xray-sdk` was used. The problem is that we need to be able to continue using those plugins without being dependent on `aws-xray-sdk`.

In this PR I propose to remove this dependency, and to use the `Options` interface defined in `utils` to define the interfaces of each dependent plugins.
This allows a simpler management of types, in case of update of `aws-xray-sdk`, we will have only one element to modify. The type of `awsClientCapture` in `utils.Options`.

There are some plugins that use only one part of the attributes of the "Option" interface, for this case I use the typescript utility type : [`Pick`](https://www.typescriptlang.org/docs/handbook/utility-types.html#picktype-keys)
    J4YM committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    3aeabd1 View commit details
    Browse the repository at this point in the history