Finish refactor #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add a progressbar * Fix a bug when looking up state_id * Add a ‘name’ index on states table * Add a switch to generate individual csv files * Refactor a few more things
midwire
force-pushed
the
feature/5-finish-refactor
branch
from
0c868b1
to
ada8e60
Compare
midwire
force-pushed
the
feature/5-finish-refactor
branch
from
46063f6
to
678a51c
Compare
midwire
force-pushed
the
feature/5-finish-refactor
branch
from
678a51c
to
50cd649
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #5
Description:
Full processing of
1,264,495zipcodes into the 4 tables and csv files takes about 17 minutes on my iMac but it is pretty beefy with 32G of RAM. I’m guessing it will take between 15-30 minutes on average.All US zipcodes takes about 17 seconds.