-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[zone parser] disallow nested $GENERATE directive #1033
Conversation
fa22be0
to
7663045
Compare
fixing test.... had the line number wrong. |
Codecov Report
@@ Coverage Diff @@
## master #1033 +/- ##
==========================================
+ Coverage 54.91% 54.92% +0.01%
==========================================
Files 41 41
Lines 9866 9869 +3
==========================================
+ Hits 5418 5421 +3
Misses 3425 3425
Partials 1023 1023
Continue to review full report at Codecov.
|
While the range number of GENERATE is now limited, one can pass a line with 2 $GENERATE directive that will exponentially increase the time spent generating RRs. Limit to only one per line. Fixes miekg#1020
7663045
to
e9aa97b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This is exactly what I meant. It's up to @miekg to decide if the behaviour change is desired.
What's the behaviour change? The desc and possibly the commits are not
saying anything on this.
Code wise lgtm
…On Wed, 23 Oct 2019, 08:54 Tom Thorogood, ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM. This is exactly what I meant. It's up to @miekg
<https://github.com/miekg> to decide if the behaviour change is desired.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1033?email_source=notifications&email_token=AACWIWYJA43QRN4O4B4DWALQP77LXA5CNFSM4JD2V5WKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCI4ILCY#pullrequestreview-305694091>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACWIWZBW747QICQYXPUPHDQP77LXANCNFSM4JD2V5WA>
.
|
@miekg Just that previously $GENERATE in $GENERATE was allowed (though I can't imagine anyone using it) and now it's disallowed. |
Thanks. I think changing that is fine. So lgmt
…On Wed, 23 Oct 2019, 09:34 Tom Thorogood, ***@***.***> wrote:
@miekg <https://github.com/miekg> Just that previously $GENERATE in
$GENERATE was allowed (though I can't imagine anyone using it) and now it's
disallowed.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1033?email_source=notifications&email_token=AACWIWYW4HPBF4E2HALCZSDQQAEDBA5CNFSM4JD2V5WKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECASDWI#issuecomment-545333721>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACWIW45RVXCQZWGMGNWBVTQQAEDBANCNFSM4JD2V5WA>
.
|
While the range number of GENERATE is now limited, one can pass a line with 2 $GENERATE directive that will exponentially increase the time spent generating RRs. Limit to only one per line. Fixes miekg#1020
While the range number of GENERATE is now limited, one can pass
a line with 2 $GENERATE directive that will exponentially increase the
time spent generating RRs.
Limit to only one per line.
Fixes #1020