Toolbar class bindings #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 4, 2016 04:59
…or usage to the dummy app and a test for it.
* master: Checkbox & switch examples layout (#361)
| integration: true | ||
| }); | ||
|
|
||
| test('should bind class names correctly', function(assert) { |
There was a problem hiding this comment.
let's test for md-tall class only.
We'll probably add md-default-theme to another place in the code base soon.
|
There are still many things to do on toolbars, but there's no harm in accepting this. |
eriktrom
added a commit
to eriktrom/ember-paper
that referenced
this pull request
May 6, 2016
* master: Add missing trailing EOL in paper-toolbar-test.js. Remove self-closing tags in dummy app sidenav. fix self closing tags Add missing trailing EOL in paper-toolbar.hbs. update toolbars (adopted-ember-addons#367) use double quotes contributing.md: Add comments to coding style. Update changelog.md. Fix npm 2.x build failures for angular-material-source dependency (adopted-ember-addons#364) Toolbar class bindings (adopted-ember-addons#362) md-button class bindings (adopted-ember-addons#365) progress-circular dummy app: Restore previous behavior inadvertently commented out. progress-circular & -linear dummy app: Start/stop progress when route is activated/deactivated. link directly to `ember-route-action` helper (adopted-ember-addons#363) Bump version to `1.0.0-alpha.0`. dummy app: Make version extremely apparent. contributing.md: Document building and deploying dummy app to github.io. Checkbox & switch examples layout (adopted-ember-addons#361) # Conflicts: # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New tall class name binding for paper-toolbar, with test and example in documentation. Let me know what I can do to improve the test, I am still new to Ember and testing with it.