Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert tfoot/row/cell to glimmer #353

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

sly7-7
Copy link
Contributor

@sly7-7 sly7-7 commented Feb 4, 2021

related to #344
cc/ @bgantzler (or @cah-briangantzler ?)

I will rebase when #352 is merged.
I basically did the same work as in #351

@cah-brian-gantzler
Copy link

When you are able, if you rebase this branch, the failing tests will no longer fail. You will also notice a couple empty constructors now, you can remove them. You may then get a lint warning that the entire class is no longer needed. you can add

// eslint-disable-next-line ember/no-empty-glimmer-component-classes

above the class to disable that lint

@sly7-7
Copy link
Contributor Author

sly7-7 commented Feb 11, 2021

Hi @cah-briangantzler , @miguelcobain, I can't unfortunately update this pr before Sunday evening, when I come back home. Obviously I will be glad to do it, but if you want to put this forward, this is not a pb for me. Do as you want 🙂

@cah-brian-gantzler
Copy link

Im in no hurry, got other things to do, take your time

@miguelcobain
Copy link
Owner

@sly7-7 we can remove the deprecation since we are major bumping.

@miguelcobain
Copy link
Owner

@cah-briangantzler please give this a quick review as well. But everything looks fine to me.

@cah-brian-gantzler
Copy link

Looks like it pretty much mirrors the body/row/cell as it should. Looks good to me

@miguelcobain miguelcobain merged commit 403d75c into miguelcobain:master Feb 15, 2021
@sly7-7 sly7-7 deleted the migrate-tfoot-to-glimmer branch February 15, 2021 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants