Updated column to glimmer. Updated yeti-table to remove most use of get/set in prep for glimmer #376
Conversation
…et/set in prep for glimmer
| } | ||
| set visible(value) { | ||
| this._visible = value; | ||
| } |
There was a problem hiding this comment.
@cah-briangantzler are you aware about the @localCopy decorator of the https://github.com/pzuraq/tracked-toolbox project?
I think this is a perfect fit for these situations and get a rid of some boilerplate.
There was a problem hiding this comment.
I had used the @cached from toolbox, but replaced with the polyfill. Forgot about the localCopy. I did this a lot more in the yeti-table.js that will be next PR and had considered writing my own. Good call out
|
Looks like @localcopy is not compatible with 3.16, next LTS that works is 3.20. Tracked-toolbox says it is compatible with 3.8, but its ember try scenarios do not actually test that. I also found this issue tracked-tools/tracked-toolbox#17 Stick with my boiler plate code that I will improve some, or go with this and raise min level to ember 3.20? |
| @@ -40,7 +40,8 @@ | |||
| "ember-auto-import": "^1.10.1", | |||
| "ember-cli-babel": "^7.23.1", | |||
| "ember-cli-htmlbars": "^5.3.1", | |||
| "ember-decorators": "^6.1.1" | |||
| "ember-decorators": "^6.1.1", | |||
There was a problem hiding this comment.
We can probably drop ember-decorators at this point, right?
There was a problem hiding this comment.
I think we have to wait til I convert yeti-table proper to drop ember-decorators
|
@cah-briangantzler I wouldn't mind supporting 3.20+ or whatever tracked-toolbox supports (as I understand it, it would be 3.8+ except 3.16). Ember 3.20 is 9 months old at this point and there are 2 LTS versions after 3.8. Also, it seems like 3.16 is not receiving bugfixes anymore:
|
|
Although tracked toolbox says 3.8+ I dont believe that is correct because of 3.16 Unless there is a fix put out, 3.20+ would be the new min. If you are fine with 3.20 Ill change the ember-try |
|
Weird that it looked like to did an ember try on 3.16 when I removed it from the scenarios. Going to close this PR and open a new one to see what happens |
Updated for glimmer. #344