Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add get_current_power to power monitoring plugs #110

Merged
merged 4 commits into from
Aug 21, 2023
Merged

Add get_current_power to power monitoring plugs #110

merged 4 commits into from
Aug 21, 2023

Conversation

Michal-Szczepaniak
Copy link
Contributor

Related issue #109

I've somehow managed to implement it (and tested it) without prior rust knowledge

@mihai-dinculescu
Copy link
Owner

Thank you for this.

Are you sure this is your first time writing Rust? :) The PR is almost flawless.
Can you please run cargo fmt and commit the changes?

@Michal-Szczepaniak
Copy link
Contributor Author

Sure will do.

First time writing rust,
but not first time programming :P

@mihai-dinculescu
Copy link
Owner

Ah, cargo clippy has a few complaints as well.

@Michal-Szczepaniak
Copy link
Contributor Author

yes yes I'm already ahead of you :P

@mihai-dinculescu mihai-dinculescu merged commit a7c45fe into mihai-dinculescu:main Aug 21, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mihai-dinculescu mihai-dinculescu mihai-dinculescu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Michal-Szczepaniak @mihai-dinculescu