Scatter instance Prettys again with .hs-boot
#847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My first plan was to place all `instance Pretty`s in `HIndent.Pretty` to remove existing instances for GHC's AST while not being affected by the AST's recursive structure, but it turned out that even our own AST couldn't avoid the recursive structure. Thus, I scatter the instances again with a `.hs-boot` file.
mihaimaruseac
approved these changes
Mar 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the PR
It turned out that we couldn't place
instance Prettys in each AST nodemodule without allowing the circular dependency because of the recursive
structure of Haskell's AST, unfortunately.
Checklist