Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore "intent://" urls on webview #1193

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Ignore "intent://" urls on webview #1193

merged 1 commit into from
Sep 5, 2024

Conversation

bapeey
Copy link
Contributor

@bapeey bapeey commented Sep 5, 2024

Webview can't handle intent:// urls, returning true cancels the request.
Issue example: keiyoushi/extensions-source#3810

@AntsyLich
Copy link
Member

Shouldn't the blob:http case also return true?

@bapeey
Copy link
Contributor Author

bapeey commented Sep 5, 2024 •
edited
Loading

Shouldn't the blob:http case also return true?

Seems like webview can handle that by default (but not loadUrl(...))

@AntsyLich AntsyLich merged commit b56a97b into mihonapp:main Sep 5, 2024
1 check passed
@bapeey bapeey deleted the intents branch September 5, 2024 14:41
cuong-tran pushed a commit to komikku-app/komikku that referenced this pull request Sep 5, 2024
@bapeey @cuong-tran
Ignore "intent://" urls on webview (mihonapp/mihon#1193)
8fa56c5 
ignore intent urls

(cherry picked from commit b56a97b)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bapeey @AntsyLich