Add Support for 7zip archives #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Would it be possible to throw a custom error similar to what we do for Rar 5? |
|
And maybe a toast when opening the slow ones |
AntsyLich
requested changes
Jan 19, 2024
core/src/main/java/eu/kanade/tachiyomi/util/storage/SevenZUtil.kt
Outdated
Show resolved
Hide resolved
FooIbar
reviewed
Jan 29, 2024
app/src/main/java/eu/kanade/tachiyomi/ui/reader/loader/ChapterLoader.kt
Outdated
Show resolved
Hide resolved
FooIbar
reviewed
Jan 29, 2024
app/src/main/java/eu/kanade/tachiyomi/ui/reader/loader/SevenZipPageLoader.kt
Outdated
Show resolved
Hide resolved
FooIbar
reviewed
Jan 29, 2024
source-local/src/androidMain/kotlin/tachiyomi/source/local/LocalSource.kt
Outdated
Show resolved
Hide resolved
stevenyomi
reviewed
Jan 29, 2024
source-local/src/commonMain/kotlin/tachiyomi/source/local/io/Format.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # app/src/main/java/eu/kanade/tachiyomi/ui/reader/loader/ChapterLoader.kt # core/common/src/main/kotlin/eu/kanade/tachiyomi/util/storage/SevenZUtil.kt # source-local/src/androidMain/kotlin/tachiyomi/source/local/LocalSource.kt
# Conflicts: # app/build.gradle.kts # app/src/main/java/eu/kanade/tachiyomi/ui/reader/loader/ChapterLoader.kt # core/common/build.gradle.kts # source-local/build.gradle.kts
FooIbar
reviewed
Feb 4, 2024
AntsyLich
requested changes
Feb 4, 2024
core/common/src/main/kotlin/eu/kanade/tachiyomi/util/storage/SevenZUtil.kt
Outdated
Show resolved
Hide resolved
core/common/src/main/kotlin/eu/kanade/tachiyomi/util/storage/SevenZUtil.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: AntsyLich <[email protected]>
more like a workaround
Suggest providing an option to open the new file with another app, for example perfect viewer or a file manager. Oddly, there is a feature request closed by the author for ppmd support in commons compress from 2014 |
that's out of the scope of this pr |
|
did a little oopsie |
|
Supersedes by #949 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
basically users can now use 7z and cb7 files to read their manga.
intended to close issue #10121 from original tachi repo
Thanks to @Claudemirovsky for the help getting this to work
Notes:
so in the end, supported compression methods are: Deflate, BZip2, LZMA and LZMA2.