fix: storage permission request for non-conforming devices #726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntsyLich
requested changes
May 4, 2024
app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDataScreen.kt
Outdated
Show resolved
Hide resolved
AntsyLich
reviewed
May 18, 2024
app/src/main/java/eu/kanade/presentation/more/settings/screen/SettingsDataScreen.kt
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-opened #645 due to me doing a wrong
rebase.Fixes #395.
I had the same issue with a news app I've programmed.
These devices run a custom Android OS that does not correctly implement the SAF. The
FileProviderthat is responsible for handling theOPEN_DOCUMENT_TREEIntentprobably does not set thePERSISTABLE_URIflag. Thus, the call totakePersistableUriPermissionfails with aSecurityException; no valid tickets are available.This workaround gets the user passed the onboarding screen. I have tested this using manga I bought online and the default file path of
/Mihon.I want to note that, after selecting the file path during the onboarding experience, the app would still tell me
No folder has been selected, but the next button was clickable. I think the issue is that the selected path is the default path, thus the validation logic assumes no (custom) path has been selected.To make this work with @rpr13 's device, one would have to add the model name to the list.