-
Notifications
You must be signed in to change notification settings - Fork 322
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
3 changed files
with
2,506 additions
and
2,939 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ | |
}, | ||
"rules": { | ||
"space-before-function-paren": 0, | ||
"no-prototype-builtins": 0, | ||
"no-control-regex": 0 | ||
} | ||
} |
Oops, something went wrong.
8f136d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a breaking change - some modules have dropped support for node 6 (which is fine in and of itself as it's EOL, but this commit was released as a patch)
8f136d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimenB - Thanks for catching that and pointing it out! @mikaelbr - it looks like this was tagged in git as released but not actually pushed to npm? If that's the case we should probably wait to include these bumps in v6 and un-tag it.
8f136d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like it has been untagged as latest, but it's definitely published
https://github.com/facebook/jest/pull/8831/files#diff-0fee7f28fe36fce7e695842f36311e39R25
8f136d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimenB Jeez, this is some terrible version management on my part. Sorry, all. I'll deprecate and release a patch reverting the breaking changes. It just didn't pay any attention and figured the breaking changes was all with devdependencies.
8f136d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No worries 🙂
8f136d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've deprecated the
5.4.2
version now, this should cause 5.4.1 to be used and avoid the issue. Let me know if there's anything else, @SimenB .@jnielson94 I've also restructured and changed the master branch a bit (reverting breaking changes) to make it easier to do patch releases up until v6. I've moved the new breaking changes to v6 branch and created a WIP PR. But we should get the breaking changes out sooner rather than later. Should get snoreToast upgrade also
8f136d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you release a
5.4.3
with the reverts just to be safe?EDIT: Oh, never mind 1101e6d 😀 Can you publish it as well?
8f136d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SimenB It's published now. Would love if it you could verify that everything works as expected. There were some manual back and forth commit handling with reverting to make this happen, so hopefully I got everyone of them
8f136d9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, works great! Thanks 🙂 jestjs/jest@b09de2d
It was only
is-wsl
that was breaking (for consumers at least) btw, upgradingsemver
should be safe