Upgrades snoretoast to 0.6.0 #288
Conversation
|
Not sure where it belongs, but I noticed that SnoreToast took away the Other than that, I'm not aware of anything in the new version that would break what we're doing... and I'm traveling so I don't have access to my windows machine for a few days ;) I'd be fine if we merge it into v6 and I just test it on that branch later. |
There was a problem hiding this comment.
These changes look good! I'm excited that you switched it to utilize the right version of the library :)
Once we remove the documentation around the wait option that is always on now (we might want to mention that it is always on in the changelog/upgrade notes?), I think this will be good to go.
|
A good catch! I looked around for breaking changes with snoretoast but didn't see that (wasn't in the changelog?). I'm updating it now. I don't have access to Windows at the moment my self, so this is done in the blind 😬 I'm planning to do a VM later, but it's a hassle also. I think it's fine to test in the v6 branch. |
There was a problem hiding this comment.
Looks good to me! We should add a task to the v6 list to make sure to test this guy out more on Windows, but code-wise it looks like it ought to work. I only noticed the wait change when I was looking at the diff for v0.5.2 to v6.0.0 ( KDE/snoretoast@v0.5.2...master#diff-04c6e90faac2675aa89e2176d2eec7d8 )
This PR upgrades snoretoast to 0.6.0 and adds support for booth x64 and x86 (similar to notifu).
Currently not using the new features of snoretoast, but I figured it's more important to do the change and we can add buttons/textbox as a minor release later.
This increases the total bundle size with 5 MB though.