Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made encodeQueryElement public #42

Merged
merged 1 commit into from
May 5, 2017
Merged

Made encodeQueryElement public #42

merged 1 commit into from
May 5, 2017

Conversation

Entea
Copy link
Contributor

@Entea Entea commented May 2, 2017

Closes #41

@coveralls
Copy link

coveralls commented May 2, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 90.541% when pulling 162d1e1 on Entea:patch-1 into 366a03b on mikaelhg:master.

@mikaelhg mikaelhg self-assigned this May 2, 2017
@mikaelhg
Copy link
Owner

mikaelhg commented May 3, 2017

All right. For symmetry's sake, could you add a commit which makes Decoder's methods public as well?

@mikaelhg mikaelhg merged commit 206b9c4 into mikaelhg:master May 5, 2017
@mikaelhg
Copy link
Owner

mikaelhg commented May 5, 2017

Oh well, I'll do it.

mikaelhg added a commit that referenced this pull request May 5, 2017
@mikaelhg
Publish all relevant methods in Encoder and Decoder, to make #41 and #42
ace27dc 


changes symmetrical.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mikaelhg mikaelhg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Entea @coveralls @mikaelhg