Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rm thiserror dep in favor of hand made error #147

Merged
merged 2 commits into from
Jun 14, 2023
Merged

Rm thiserror dep in favor of hand made error #147

merged 2 commits into from
Jun 14, 2023

Conversation

bheylin
Copy link
Contributor

@bheylin bheylin commented Jun 12, 2023

Closes #146

mikaelmello
mikaelmello previously approved these changes Jun 14, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@mikaelmello
Copy link
Owner

Thanks for your contribution! I found it valuable to get that kind of perspective on the improvements that can be made.

@bheylin
Copy link
Contributor Author

bheylin commented Jun 14, 2023

Thanks for your contribution! I found it valuable to get that kind of perspective on the improvements that can be made.

Do worries! I'm optimizing an xtask project atm, so I'm hyper focused on dependencies and their cost / value.
Thanks for the quality crate 😉

@mikaelmello mikaelmello merged commit 4c0ed85 into mikaelmello:main Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikaelmello mikaelmello mikaelmello approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove thiserror dep to avoid indirect dep on syn
2 participants
@bheylin @mikaelmello