Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command-c save does not save diagram #43

Closed
jimraynor0 opened this issue Jan 24, 2019 · 3 comments
Closed

Command-c save does not save diagram #43

jimraynor0 opened this issue Jan 24, 2019 · 3 comments

Comments

@jimraynor0
Copy link

Reproduce steps:

  1. Create a new threat model
  2. Add a new diagram
  3. Save
  4. Edit diagram
  5. Add a process to the diagram
  6. Hit command+s
  7. Hit command+o, open the previously saved threat model
  8. Edit diagram again

Expected behavior:
Diagram should contain one process

Actual behavior:
Diagram is empty

@josephthweatt
Copy link

I am experiencing the same issue. Additional details:

  • Using Mac
  • Downloaded threatdragon-darwin-x64.zip from 0.1.26
  • I used command+s to save, although I noticed the command to save in Threatdragon is command+c for some reason. In any case neither work.
  • Creating a new file after editing the project basically just copies the initial project, so you just get a duplicate project with no saved edits.
  • On one occasion Threatdragon deleted my project's json, leaving the file with a single null value in it.

Is there any plan to resolve this soon?

@mike-goodwin
Copy link
Owner

Thanks for submitting this - I'm looking into it. In the meantime, your workaround is to use the save button on the diagram editor. This correctly saves the diagrams as far as I can tell.

mike-goodwin added a commit that referenced this issue Jun 14, 2019
@mike-goodwin
Copy link
Owner

mike-goodwin commented Jun 14, 2019

The original issue from @jimraynor0 - diagram not saving is fixed and will be included in the next desktop release. Note currently this is tested only on Windows since I don;t have access to a Mac at the moment. Also, from the same commit save is now Ctrl-S or command-S like the rest of the civilised world ;)

I believe the 3rd bullet point in the comment from @josephthweatt is also fixed, but I was not exactly clear on the steps to reproduce so please re-open this or a new issue if you find it is still broken when the release comes out.

Also note: Autoupdate is not working for the Mac version because I don't have a code signing cert still so you will have to manually download the new version v0.1.28 when it is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants