Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use electron-builder to build and publish all targets #131

Merged
merged 5 commits into from
Apr 9, 2020

Conversation

fajabird
Copy link
Contributor

@fajabird fajabird commented Apr 9, 2020

added build block for electron-builder for all targets (mac, win, linux (deb, rpm, appimage, snap)
added dist script for all platforms and automatic publishing (-mwl --publish always)

@jgadsden jgadsden self-requested a review April 9, 2020 09:11
@jgadsden jgadsden linked an issue Apr 9, 2020 that may be closed by this pull request
Copy link
Collaborator

@jgadsden jgadsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @fajabird - we have a Travis build failure because
of the extra , for "provider": "github", , Travis is quite strict :-)
and this gives this Travis error:

npm ERR! Trailing comma in object at 35:7
294npm ERR!       },
295npm ERR!       ^

remove comma from line "provider": "github" as travis complianed about this.
@codecov
Copy link

codecov bot commented Apr 9, 2020

Codecov Report

Merging #131 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #131   +/-   ##
=======================================
  Coverage   98.23%   98.23%           
=======================================
  Files           6        6           
  Lines         226      226           
=======================================
  Hits          222      222           
  Misses          4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 380f3d3...a6ed7ff. Read the comment docs.

@jgadsden jgadsden self-requested a review April 9, 2020 10:57
Copy link
Collaborator

@jgadsden jgadsden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great and works well, thankyou. There are some extras that can be done, such as providing the icons, but this can be done at a later date if we want.
@fajabird shall I go ahead and merge? All tests have passed

@fajabird
Copy link
Contributor Author

fajabird commented Apr 9, 2020

Yes go ahead. the build section contains all relevant targets so scratch those not needed or not supported on a particular build system. Also adopt the dist script parameters. After that you can use the same command on all systems, i.e. npm run dist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide Linux distribution independent packages
2 participants