-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use electron-builder to build and publish all targets #131
Conversation
added dist script for all platforms and automatic publishing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @fajabird - we have a Travis build failure because
of the extra ,
for "provider": "github",
, Travis is quite strict :-)
and this gives this Travis error:
npm ERR! Trailing comma in object at 35:7
294npm ERR! },
295npm ERR! ^
remove comma from line "provider": "github" as travis complianed about this.
Codecov Report
@@ Coverage Diff @@
## master #131 +/- ##
=======================================
Coverage 98.23% 98.23%
=======================================
Files 6 6
Lines 226 226
=======================================
Hits 222 222
Misses 4 4 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and works well, thankyou. There are some extras that can be done, such as providing the icons, but this can be done at a later date if we want.
@fajabird shall I go ahead and merge? All tests have passed
Yes go ahead. the build section contains all relevant targets so scratch those not needed or not supported on a particular build system. Also adopt the dist script parameters. After that you can use the same command on all systems, i.e. npm run dist. |
added build block for electron-builder for all targets (mac, win, linux (deb, rpm, appimage, snap)
added dist script for all platforms and automatic publishing (-mwl --publish always)