Implemented threat model report #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new route, controller and template uses new report directive from core
just tests controller instantiation, no real business logic yet
also tidied some of the shell code
came across an electron bug electron/electron#19008 That means a hack is needed to keep the app running if print is cancelled
plus fixed json stringify bug
Codecov Report
@@ Coverage Diff @@
## development #55 +/- ##
===============================================
- Coverage 97.67% 94.14% -3.53%
===============================================
Files 3 6 +3
Lines 86 188 +102
===============================================
+ Hits 84 177 +93
- Misses 2 11 +9
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.