add LTO, add O3 builds for Linux at Release #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not super concerned about file size, but I'm good with improvements there if it doesn't impact performance. Not sure about O3 instead of the existing Ofast (which should be doing the same optimization as O3, but with the addition of fast-math). |
|
Valid point, let's go with LTO only.
|
|
Why the change from cxx_std_17 to cxx_std_20? |
|
Why the change from cxx_std_17 to cxx_std_20?
Project's main target standard is set to C++20. I can revert this.
|
Fair point. Why don't you remove it from this PR, though, unless it is required for LTO. I added an issue to fix the c++ version mismatch: #64 |
|
I'm not seeing a size decrease in the github builds. The shared library is 297K without LTO in the current github build: It looks to be the same size with your PR: |
|
Ok, so I completely missed LTO is already turned on in src/CMakeLists.txt:45
Closing this PR.
|
|
Hey, at least now I know that I'm doing LTO... 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
LTO decreases binary size from 1.5MB to 400kB, along with O3 it drops down to
300kB.