Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply excludeFields only to fields in Library #1015

Merged
merged 6 commits into from
Aug 23, 2024

Conversation

SageDroid
Copy link
Contributor

Resolves #1014

Currently this solution removes the possibility to remove the metadata object from the output. It has never been documented that this works, but there may still be people who rely on it. If you think this is a problem, I have two ideas on how to solve it:

  1. Apply PartialObjectConverter for MetaData as well
    or
  2. Add a new parameter in the configuration, e.g. excludeMetaData

What do you think?

@mikepenz mikepenz merged commit 3f13319 into mikepenz:develop Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"excludeFields" is applied to all fields and not just to the fields in "Library"
2 participants