COMMIT mode not returned when commitMode is true #1351
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key issues:
commitMode
istrue
, the function always skips the block that should return 'COMMIT'.mode
parameter whencommitMode
istrue
, which is counterintuitive.commitMode
totrue
never guarantees a 'COMMIT' return value as it should.Proposed changes:
commitMode
parameter.commitMode
istrue
, the function always returns 'COMMIT', regardless of themode
value.mode
values whencommitMode
isfalse
.