Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMMIT mode not returned when commitMode is true #1351

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

pajikos
Copy link
Contributor

@pajikos pajikos commented Jul 31, 2024

Key issues:

  1. When commitMode is true, the function always skips the block that should return 'COMMIT'.
  2. The function only considers the mode parameter when commitMode is true, which is counterintuitive.
  3. As a result, setting commitMode to true never guarantees a 'COMMIT' return value as it should.

Proposed changes:

  1. Restructure the function logic to prioritize the commitMode parameter.
  2. Ensure that when commitMode is true, the function always returns 'COMMIT', regardless of the mode value.
  3. Maintain the existing logic for handling different mode values when commitMode is false.

@pajikos pajikos changed the title Fix bug in resolveMode function: COMMIT mode not returned when commitMode is true COMMIT mode not returned when commitMode is true Jul 31, 2024
@mikepenz mikepenz merged commit 13f7fbe into mikepenz:develop Aug 2, 2024
@mikepenz mikepenz added the fix label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants