Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow optionally passing spec object into init to override it. #47

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

johnsusek
Copy link
Contributor

@johnsusek johnsusek commented Sep 27, 2018

When using this in dev vs prod, we override the spec at build time with a different host and securityDefinition.

The spec object becomes a new optional param to init here.

@mikestead mikestead self-assigned this Oct 20, 2018
@MariusVolkhart
Copy link

@johnsusek could please also update service.ts.template with the same changes?

@MariusVolkhart
Copy link

🎉 thanks @johnsusek

@johnsusek
Copy link
Contributor Author

done! let me know if I should change anything, I'm not very familiar with typescript

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants