Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeouts and retries #10

Closed
Bfgeshka opened this issue Mar 10, 2017 · 2 comments
Closed

Timeouts and retries #10

Bfgeshka opened this issue Mar 10, 2017 · 2 comments

Comments

@Bfgeshka
Copy link

As far as I see, gallery-dl in current state cannot detect stalled download. These are vital for grabbing big galleries, so I request to add arguments for num. of retries and timeout intervals in future release.

@mikf
Copy link
Owner

mikf commented Mar 31, 2017

New release is out and the features you requested should be implemented.
22910f9 really improved the way errors are handled and all exceptions that can be dealt with are caught. I'm ignoring OSErrors ("no space left on device", "no permission", etc) as there is nothing I can do about them and retrying isn't going to help either.
The timeout option gets directly used as the timeout parameter for the requests.get call (as documented here) and sets both the connect and read timeout.
The retry option effects the amount of times my own code tries to download a file. It doesn't touch the requests/urllib3 options, but I think this is good enough.

If you have any other suggestions or features you want to see implemented in this regard, let me know. Otherwise I think this issue can be closed.

@Bfgeshka
Copy link
Author

Tried it out, seems working so far.

Thanks for your effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants