Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] [deviantArt] Won't download Flash animations if preview image is GIF, only downloads preview image instead. #1731

Closed
a-washing-machine opened this issue Jul 28, 2021 · 3 comments

Comments

@a-washing-machine
Copy link

a-washing-machine commented Jul 28, 2021

gallery-dl won't download Flash animations, if the preview image is an (animated?) GIF. Instead of the swf file, only the preview image is downloaded.

Examples:

Flash with GIF as preview image only downloads the preview file:
https://www.deviantart.com/yuumei/art/Flash-Comic-Tutorial-214724929

Flash with static preview image downloads the Flash animation just fine:
https://www.deviantart.com/madelief/art/Flash-Tutorial-for-Newbies-23360228

Ideally, I'd actually like to download both the artwork AND preview image, but ONLY if the artwork is something other than a typical image or video file.

Say, if the artwork is a zip-archive, an svg file, or a pdf, etc. In this case, downloading both would make sense; many such file formats (including Flash) have no preview (pdf files aren't consistent about having previews or not), and having a quick overview of "what's there" when checking a folder is helpful, when the folder is full of flash files. If the artwork itself is a normal image or a commonly used video format, then downloading the preview of course wouldn't make sense.

As an aside, I've noticed an edge case that deviantArt themselves doesn't handle unfortunately - a Flash animation with "download disabled" is now inaccessible through the site, and gallery-dl also does not download it. :( Can this oversight on deviantArt's part be circumvented with gallery-dl somehow?

Example:
https://www.deviantart.com/dcleadboot/art/Sonic-and-Danbuster-Ep2-92092625

@mikf
Copy link
Owner

mikf commented Jul 29, 2021

Animated GIFs had a bug where preview and original were switched (#242). gallery-dl compensates for that by only returning the "preview" for those.
This seems to now be fixed on dA's end, so just removing this check should work.

Can this oversight on deviantArt's part be circumvented with gallery-dl somehow?

Doesn't appear to be possible. Requesting the original file for your example just returns an error.

{"error":"invalid_request","error_description":"Deviation not downloadable.","error_code":2,"status":"error"}

@a-washing-machine
Copy link
Author

Ah, good to hear. :)

Doesn't appear to be possible. Requesting the original file for your example just returns an error.

Yeah I kinda figured as much. Another victim of the Eclipse. :(

@a-washing-machine
Copy link
Author

Thanks for fixing the bug so fast! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants