Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Instagram] Only one image of multi-image posts gets downloaded #178

Closed
arisboch opened this issue Mar 3, 2019 · 4 comments
Closed

[Instagram] Only one image of multi-image posts gets downloaded #178

arisboch opened this issue Mar 3, 2019 · 4 comments
Labels
bug enhancement

Comments

@arisboch
Copy link

arisboch commented Mar 3, 2019

I tried to download Instagram posts with more than one image in one post, but I only got one image. Is it possible to download them all?
@Hrxn
Copy link
Contributor

Hrxn commented Mar 3, 2019

gallery-dl/gallery_dl/extractor/instagram.py

Lines 34 to 39 in cd3bbd1

elif data['typename'] == 'GraphSidecar':
# TODO: Extract all images in edge_sidecar_to_children
# TODO: instead of just extracting the main one!
yield Message.Url, data['display_url'], \
text.nameext_from_url(data['display_url'], data)
elif data['typename'] == 'GraphVideo':

TODO / Not yet implemented 😊

@iamleot
Copy link
Contributor

iamleot commented Mar 3, 2019 via email

@arisboch
Copy link
Author

arisboch commented Mar 3, 2019 •
edited
Loading

@iamleot

do not hesitate to contact me if you would like to try implementing that!

That'd be great. Thanks in advance.

@iamleot iamleot mentioned this issue Mar 23, 2019
Merged
@iamleot
Copy link
Contributor

iamleot commented Mar 23, 2019

@arisboch applying the patch in pull request #201 should do the trick! Please let me know if it's missing anything!

@mikf mikf closed this as completed in #201 Mar 24, 2019
mikf pushed a commit that referenced this issue Mar 24, 2019
@iamleot @mikf
[instagram] Add support for GraphSidecar media types (#201)
1e38f65 
* [instagram] Add support for GraphSidecar media types

Refactor _extract_postpage() to always return a list of medias.

Fetch common keywords and gracefully handle GraphSidecar media type
by extracting each single media and adding `sidecar_media_id' and
`sidecar_shortcode' keywords to indicate the parent of sidecar
childrens.

While here join the copyright comment lines in a single one.

Closes #178.

* [instagram] Use `yield from' instead of `for ... yield' (thanks @mikf)!

* [instagram] Adjust filename for GraphSidecar medias

Add a possible leading `media_id' of the sidecar for GraphSidecar
media.

Thanks to @mikf for the suggestion!

* [instagram] Add extra metadata for youtube-dl in GraphSidecar childrens

GraphSidecar children ytdl: URLs when consumed by youtube-dl
redirects to the URL of their parent.  In GraphSidecar-s with
multiple GraphVideo-s this leads to downloading the same video
multiple times.

Add a `_ytdl_index' field to indicate the index of the youtube-dl
playlist corresponding the children of the sidecar.

This will be used by the `ytdl' downloader.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@arisboch @mikf @iamleot @Hrxn