-
-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[twitter] -o text-tweets=true
now downloads reply target's posts
#2712
Comments
Wait, it's not retweets. It's media (and descriptions) of other profiles from the target profile replies to. I want to download only content of the passed profile, without any content of other profiles. |
-o text-tweets=true
disables "retweets": false
now-o text-tweets=true
now downloads reply target's posts
This is why I said to set the default value for To be precise, it must be set to timeline/replies extractor only I guess Anyway, |
I just passed https://github.com/mikf/gallery-dl/blob/master/docs/configuration.rst#extractortwitterreplies I want to download in this case all profile's media posts. Something like |
Actually, I just tested and it definitely doesn't work right. For example: https://twitter.com/amanatsu_mikan7/with_replies (NSFW)
|
i've been having similar issues since the update to 1.22.2 and i've found out another weird thing, |
it also seems similar to the problem in #2713 since all of these problems run back to getting data from user adjecent to the one specified with the link |
Same thing. Logged off = non-target user tweets are not included in the replies. Details. None of these issues are related to the current version, they've been here for a long time. |
good to know, i still don't know why it gets post from other users while logged in though, even if it's treating the replies as retweets or quote tweets it's still handling like individual post, so you get all the folders with them, that is the main problem at hand |
Are you sure about that? Strange, because I've never experienced it here. |
The issue with |
Yes, but only for long conversations, i.e. long enough to get "truncated" by Twitter, as you've reported in another issue, if I'm not mistaken, right? |
actually |
and specifically, it leads to unexpected tweets only when logged in, it doesn't if there isn't a login which is also odd |
Yeah, it seems you're right. So it wasn't fixed then.
No, any conversations. Also it affects search, for example, and probably even
Something like that. |
it fixed something, because even while logged out i'm gettiing more images than before (like the ones in threads it was missing before) but for some reason i goes way off the handle if you're logged in and gets some tweets it shouldn't |
The "unexpected tweets only when logged in" are unrelated to I'm very much considering reverting 0add1fc and not using Also, what about an option that basically does the same as |
i forgot about filters lol but yeah it seems that an option would be optimal since it can be headache having 300 unrelated files all of a sudden |
The problem is that https://twitter.com/Anon2000000/status/1541508842269425667 the tweet which is Anon2000000 replying to is not a reply itself so gallery-dl's replies behavior is not applied here.
This is what I asked long time ago. But not as an option, rather it should be that target user's metadata would always be accessible in the keyword dictionary. So the people can write these filter's by themselves. That would also fix issues like these: #2713 |
I think that's not a good idea. I suppose people expect from gallery-dl to gather all the tweets from the timeline, and not using replies timeline could miss quite a lot, considering that an average user is probably not even aware that using |
Since 0add1fc, gallery-dl uses
You sure about that? I always thought that at least |
|
Yes, as long as it's only /media it should be fine, but when people set I also think solutions like using /media+/with_replies+/tweets timelines are ugly and not really practical. Especially when you have a quite large (500+) list of links to download. It creates unnecessary traffic and makes the whole process longer, even with all the skips of already downloaded content. Also, it can trigger twitter's time-out thing, though I'm not sure about that. |
Gallery-dl's keyword dictionary for twitter always contains |
Also, it won't make much sense without proposed thread expanding. I've seen you did an |
Regarding this issue's original topic: I've put out another release that no longer uses the The changes from 0add1fc should be re-applied at some point, but it was premature to do so in v1.22.2. |
So should I do a pass with retweets/text tweets disabled and then a pass with them enabled? |
If you only need user's media content then leave both disabled or use If you want retweets too and don't want to miss media content, then do it with two passes. If you want all text-tweets too... Well, that's complicated, the changes are reverted now, so you should use |
Is there any way to disable the new search functionality? I already had that handled as part of my script and now it's probably going to lead to a lot of API requests I don't want it to do. |
Use /tweets link, like twitter.com/user/tweets. /media and /with_replies doesn't do search as I said. |
I'm lazy to read the messages above, that I would like:
of the passed profile only, by just passing a direct profile link. Downloading of third-party retweets and commented third-party tweets is enabled with an extra config option. If it will work such way from the box I think it would be convenient and intuitively. |
I just decided to downgrade to gallery-dl 1.21.2-1 for the time being until this can be solved or how to make the folders better structured. |
to be able to better control what Tweets get used an returned for twitter.com/USER URLs.
occurs primarily for /with_replies results when logged in
@mikf All the strategy options include search, but I specifically want to avoid having it search under any circumstance. It's a lot of API calls and I handle searching elsewhere already. |
nisehime already explained that in #2712 (comment) If you don't want a search, use The search only happens for direct user URLs (
|
I see, I misunderstood what the new documentation was saying. Does that mean the workaround for getting all the tweets I described here #2712 (comment) is still necessary? If so, would it be possible for me to somehow retrieve the json of tweets for both with_replies and media, and then feed the list of urls back into gallery-dl? The new 'unique' setting seems like it would make it so it didn't have to check the same tweet twice. |
@mikf Until such an option to disable search is implemented, I figure I should modify the code for a personal copy, but looking at the code, no easy way to do it really sticks out to me. What should I do? |
The bug have appeared after the update.
I optionally use
-o text-tweets=true
only when I need to save no media tweet's text (in fact to download everything of the passed profile), since usually it is required only for some profiles.The conf:
Now when I use
ggat
it downloads theretweetsreply target posts, that is undesirable.gga
works as expected (as earlier).The text was updated successfully, but these errors were encountered: