-
-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fanbox gallery images downloading out of order (alphabetical hash) #2718
Comments
That's just a coincidence. Take https://www.fanbox.cc/@xub/posts/1910054 (NSFW) as a counter example. All files here have the same order as on fanbox itself, and the file hashes are in reverse order.
gallery-dl first downloads the cover image, followed by html embeds, images, files, and external embeds. Maybe that order is wrong for certain posts? |
Well, I lost my log from the dozens of galleries I downloaded and I'm not subbed to anything this month. Can't exactly verify anything. Is this a change that was made in the last few months and just nobody has called attention to it? Or is there some kind of command line way to download in a proper sequential order? |
The file order was like this since fanbox support got added in #1459. There have only been 2 real commits to fanbox.py which changed anything of importance since then, and they didn't touch anything related to file order:
What is the proper order? From all the examples that I have seen, the current order is fine as is, and I do not know what to change unless you (or someone) gives a proper example. |
Recently also ran into this issue. I'm not really sure how to diagnose it, but I found a post with replicable incorrect order. https://mochirong.fanbox.cc/posts/3746116 (NSFW) will download in alphabetical hash order instead of the order it appears in the article. I noticed while printing out the |
Ok I made a really shitty workaround that I'm sure somebody can retrofit or implement in a smarter way. In short, I created a new post entry called "order" that's a list based on the blocks found in Changed these lines to this -
Added this snippet above this line -
|
Thanks for the example post and code. This should be fixed in 7d6c846 for images, but I think this might also be an issue with |
I put the proper command in and it downloads the contents fine, but incorrectly in 1-9,A-Z alphabetical order of the Fanbox-side filenames which are all hashes, outputting totally out of order as [xxxxxxx]_1 and so on (the thumbnails come out as _0 just fine). I'll just include what I can and hope the solution is some totally simple filename option I've overlooked like an idiot. Sorry if the formatting isn't what it should look like.
gallery-dl -v "https://www.fanbox.cc/@foobar/posts/!@#$%^" --cookies C:\Users\xxx\Desktop\cookies.txt
[gallery-dl][debug] Version 1.20.4 - Executable
[gallery-dl][debug] Python 3.7.9 - Windows-10-10.0.18362
[gallery-dl][debug] requests 2.27.1 - urllib3 1.26.8
[gallery-dl][debug] Starting DownloadJob for 'https://www.fanbox.cc/@foobar/posts/!@#$%^'
[fanbox][debug] Using FanboxPostExtractor for 'https://www.fanbox.cc/@foobar/posts/!@#$%^'
[urllib3.connectionpool][debug] Starting new HTTPS connection (1): api.fanbox.cc:443
[urllib3.connectionpool][debug] https://api.fanbox.cc:443 "GET /post.info?postId=!@#$%^ HTTP/1.1" 200 3567
[urllib3.connectionpool][debug] Starting new HTTPS connection (1): pixiv.pximg.net:443
[urllib3.connectionpool][debug] https://pixiv.pximg.net:443 "GET /c/1200x630_90_a2_g5/fanbox/public/images/post/!@#$%^/cover/dI89euiV6NES3s9I4ZCXNYRC.jpeg HTTP/1.1" 200 364868
[urllib3.connectionpool][debug] Starting new HTTPS connection (1): downloads.fanbox.cc:443
[urllib3.connectionpool][debug] https://downloads.fanbox.cc:443 "GET /images/post/1833133/140KfbnjlFMU5jAe7IgxqHKG.jpeg HTTP/1.1" 200 None
[urllib3.connectionpool][debug] https://downloads.fanbox.cc:443 "GET /images/post/1833133/31qnHq0LNGqWEUMHB7XGE56d.jpeg HTTP/1.1" 200 None
{and so on. again, it first downloaded the images with hash filenames starting with 1 and then 3}
Netscape HTTP Cookie File
.fanbox.cc TRUE / TRUE 1659054592 FANBOXSESSID {omit}
.fanbox.cc TRUE / FALSE 1719534064 _ga GA1.2.1664558252.1656429579
.fanbox.cc TRUE / FALSE 1656462128 _gat_gtag_UA_1830249_145 1
.fanbox.cc TRUE / FALSE 1664205577 _gcl_au 1.1.1001063367.1656429577
.fanbox.cc TRUE / FALSE 1656548464 _gid GA1.2.1550279713.1656429579
.fanbox.cc TRUE / TRUE 1814109576 p_ab_d_id 141724759
.fanbox.cc TRUE / TRUE 1814109576 p_ab_id 9
.fanbox.cc TRUE / TRUE 1814109576 p_ab_id_2 0
.fanbox.cc TRUE / TRUE 1719501844 privacy_policy_agreement 3
.fanbox.cc TRUE / TRUE 1719534592 privacy_policy_notification 0
`
The text was updated successfully, but these errors were encountered: