-
-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Twitter] Add {num} to file name only if there are multiple media #2741
Comments
Wait... You can use |
He wants to use I'll probably just add a |
Sounds like a reasonable improvement, something I think I'd use as well.. Buuuut.. based on his description here:
How's that different for what the Twitter extractor is doing right now? Except that maybe num is 1 instead of 0, if there's only one image file in the post? |
The difference is that the Twitter extractor always started its enumeration at
would cause all sorts of problems for users that have downloaded files with the "old" filenames. Backwards compatibility and all that. Adding a new field at least doesn't break any existing setup. |
True, that wouldn't break anything.. |
I am aware of setting
extractor.*.filename
to an object to use different file names depending on an expression, but I can't find a way to check if a tweet has multiple media or not. I could do it with Reddit and Imgur though, as Reddit setsnum
to 0 if there's only one media, and Imgur hasimage_count
(oralbum["image_count"]
), which shows how many images there are. Here's my config file where I do it with Reddit and Imgur and try to with Twitter: gdl-config.json.gzThe text was updated successfully, but these errors were encountered: