[Sankaku] "Expired link" image is being downloaded instead of some files

[pink-red]

This mostly happens when multiple videos are downloaded from a single search. Sankaku is very slow for me, and I believe that the extractor obtains multiple URLs at once in batches (pagination?). I believe that when the downloader is at the end of the batch, there is a high chance that all of the links are already expired.

Since the expired.png file is saved instead of these files, simply retrying the same command doesn't help, since gallery-dl thinks that the problematic files were already downloaded. Only manually finding and removing these files helps with this.

Is there a way to make gallery-dl detect expired links and refresh them before downloading, or at least to skip them, to simplify retrying the download?

[mikf]

gallery-dl grabs 100 posts per batch and those download links expire after 60 minutes, so you get expired.png files if it takes you longer than that to download them all.

I made it so it fails a download if it would download such a file (8506085). Updating expired links should also be possible, but that requires a bit more effort, I think, so went with the easier solution first ...

[mikf]

The new release has a refresh option, which fetches new download links when the old ones have expired. (4089bce) It is not enabled by default since it's quite a lot of extra code, meaning it probably has a bug somewhere in it.

(This is one of the rare cases where a goto would have been helpful, by the way)