Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bcy.net] Can't download some images from user profile #3103

Closed
ayanamists opened this issue Oct 25, 2022 · 1 comment
Closed

[bcy.net] Can't download some images from user profile #3103

ayanamists opened this issue Oct 25, 2022 · 1 comment

Comments

@ayanamists
Copy link

ayanamists commented Oct 25, 2022

Action:

❯ gallery-dl https://bcy.net/u/2243624 -v
[gallery-dl][debug] Version 1.23.3
[gallery-dl][debug] Python 3.6.9 - Linux-5.15.0-48-generic-x86_64-with-Ubuntu-22.04-jammy
[gallery-dl][debug] requests 2.27.1 - urllib3 1.26.12
[gallery-dl][debug] Starting DownloadJob for 'https://bcy.net/u/2243624'
[bcy][debug] Using BcyUserExtractor for 'https://bcy.net/u/2243624'
[urllib3.connectionpool][debug] Starting new HTTPS connection (1): bcy.net:443
[urllib3.connectionpool][debug] https://bcy.net:443 "GET /apiv3/user/selfPosts?uid=2243624 HTTP/1.1" 200 None
[urllib3.connectionpool][debug] https://bcy.net:443 "GET /apiv3/user/selfPosts?uid=2243624&since=1659844915 HTTP/1.1" 200 None
[urllib3.connectionpool][debug] https://bcy.net:443 "GET /item/detail/7124477840543718408 HTTP/1.1" 200 None
[urllib3.connectionpool][debug] Starting new HTTPS connection (1): p3-bcy-sign.bcyimg.com:443
[urllib3.connectionpool][debug] https://p3-bcy-sign.bcyimg.com:443 "GET /banciyuan/ee880bbff70e43408803e69fe6d2daf1~tplv-bcyx-yuan-logo-v1:wqnmmrTouoHmr4_kuIDlpKkK5Y2K5qyh5YWDIC0gQUNH54ix5aW96ICF56S-5Yy6.image?x-expires=1682761406&x-signature=4DleA%2BUqMkv6p8jd8KBxsLfRnY4%3D HTTP/1.1" 200 2341304
./gallery-dl/bcy/2243624 暴躁每一天/7124477840543718408 196109439.jpg

This first request of user profile, this link, contains many pics. Such as this pic.

However, gallery-dl doesn't download any of them. Note the first pic to be download should be 7156841908512234504 208226221.jpg, instead of 7124477840543718408 196109439.jpg

mikf added a commit that referenced this issue Oct 26, 2022
- fix regex for non-watermarked images
- fetch data from '/item/detail' pages for all other posts,
  since '/apiv3/user/selfPosts' only has incomplete data
@mikf
Copy link
Owner

mikf commented Oct 26, 2022

This should be fixed in commit 46b6425, which also returns higher quality images than your solution in #3104.

[gallery-dl][debug] Version 1.24.0-dev - Git HEAD: c8af1f58
[gallery-dl][debug] Python 3.10.7 - Linux-5.19.13-arch1-1-x86_64-with-glibc2.36
[gallery-dl][debug] requests 2.28.1 - urllib3 1.26.12
[gallery-dl][debug] Starting DownloadJob for 'https://bcy.net/u/2243624'
[bcy][debug] Using BcyUserExtractor for 'https://bcy.net/u/2243624'
[urllib3.connectionpool][debug] Starting new HTTPS connection (1): bcy.net:443
[urllib3.connectionpool][debug] https://bcy.net:443 "GET /apiv3/user/selfPosts?uid=2243624 HTTP/1.1" 200 None
[urllib3.connectionpool][debug] https://bcy.net:443 "GET /item/detail/7156841908512234504 HTTP/1.1" 200 None
[urllib3.connectionpool][debug] Starting new HTTPS connection (1): p3-bcy-sign.bcyimg.com:443
[urllib3.connectionpool][debug] https://p3-bcy-sign.bcyimg.com:443 "GET /banciyuan/c961bc20c51d4dbebf7fc6f6f4313dc4~tplv-bcyx-yuan-logo-v1:wqnmmrTouoHmr4_kuIDlpKkK5Y2K5qyh5YWDIC0gQUNH54ix5aW96ICF56S-5Yy6.image?x-expires=1682877029&x-signature=9%2FB8nkJsWlOkjCoDrR8r3T9NTDo%3D HTTP/1.1" 200 1629452
/tmp/bcy/2243624 暴躁每一天/7156841908512234504 208226221.jpg

The bcy code has not seen any changes since early 2021, so it was very likely that something broke during that time.

@mikf mikf closed this as completed Oct 26, 2022
mikf added a commit that referenced this issue Oct 29, 2022
- fix regex for non-watermarked images
- fetch data from '/item/detail' pages for all other posts,
  since '/apiv3/user/selfPosts' only has incomplete data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants