-
-
Notifications
You must be signed in to change notification settings - Fork 975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[twitter] Images from replies are broken #4953
Comments
You can manually set |
it doesn't really work, it still misses media from tweets that are replies, and the problem with |
Set |
Hi @mikf "twitter": |
@Vladimir-russian
|
do I need [] this ? Because GAL-D doesn't work with this but if I removed [], it works "include": "all" |
Yeah, seems [] wasn't necessary. |
image-filter works, thanks |
Hi, I use following config to download images/videos and I still have to manually use
am I doing something wrong? |
@CatPlanet Set |
@mikf I've skipped not relevant and/or defaults and I ended with
just to emulate previous behavior. If only I knew this tiny "improvements" note in changelog would have such impact on application I would stop using it for a while instead of spending next few weeks getting rate limited 😣 I just wonder how many users as me will notice they're getting partial results. Anyway have a nice day, I love your project. |
It seems "replies": "self" is ignored when I pass I now get text tweets with replies to other users. |
You sure this setup is correct? It gave me a much smaller portion of the account's media tweets than I had expected (just in the double digits). I had to add ", media" to the strategy parameter to get a little over 500 media tweets before the process concluded, and even then I'm not sure if that's because the account is under a shadowban or if it's because there's still room for expanding the scope of the search. |
Only if defaults from this page are correct, yes.
I'm 90% sure this is correct setup; I haven't noticed anything missing (yet) and I get rate-limited pretty fast so 🙂 |
|
No, I just though the program could work without it, as before. |
At this point I think everyone would appreciate definitive config setup to get every media piece from given user. |
I would if I could, but I also do not know how to get "all" Tweets or if that's even possible. If I knew of a way I would most certainly make this the default setting. |
My way - which I described here seems to have more or less the same effect as the old status quo before the recent changes on Twitter's end borked it. |
If I understand your comment right and you mean setting Using an invalid/unrecognized value for |
Dammit, you're right, I just tested it with one of the accounts whose media timeline was severely demolished by the "no replies in the media timeline" BS, and it really doesn't work. EDIT 1: Currently trying the "include" parameter with the setting "tweets,media,replies". So far it seems to have the desired effect; it's not stopping at the double digits like when I first tried the suggested method here. EDIT 2: Well, here's an interesting observation. It goes through each of those categories one by one, instead of my expectation that it they're criteria to check tweets against. In hindsight, my initial assumption was obviously stupid. EDIT 3: Alright, it's done. End result is that it grabbed a lot, but unfortunately is missing much of the older stuff despite it still being provably present. I cannot tell if this is a problem unique to this account or if it's a general issue. One weird anomaly, however, is that it grabbed the text captions (but not the images) of several tweets by other accounts; the only tying factor that I could see is that they were retweeted by the actual target account. |
Is it me or are replies back in the media tab? |
Same here. Media replies appear to get listed in |
They seem to be in the correct order for me so far. Maybe this only affects some accounts, whether it's on the observer's end or the observed party's end (well, technically on Twitter's end when it fetches the data about that account). Can anyone confirm if this has affected gallery-dl's ability to fetch media tweets? |
It hasn't but what I noticed is that it will grab media replies regardless of |
Not sure I understand the problem here. |
I just tested it, and can verify that currently the app misses a very significant portion of a Twitter account's media tweets (over 80 tweets to be specific, out of a total 188 as of this writing). And this is despite the fact that I haven't changed my settings from before the media timeline was "fixed" three days ago. |
@MarqFJA87 |
@mikf Sure. Input URL: https://twitter.com/strangestone (quite a few mildly to very NSFW images, given the artist's main work is unashamedly fanservice-based) Twitter settings (omitting username, password and cookie entries), which I have been using to deal with the preceding status quo:
The verbose log is over 2000 lines long, so I'll be attaching it as a text file. Just to illustrate, the app is missing tweets as recent as this one. |
@MarqFJA87 Like I thought, it is indeed using the |
Thanks. I will report back if I notice that this method is still somehow missing some tweets. |
I ran your URL/config with both File Diff1744132052486619385_1.png
1728979297468317925_2.jpg
1728979297468317925_1.jpg
1713822791542391146_1.png
1680814663175659521_1.png
1673212921114144774_1.png
1510491123185201153_1.jpg
1432156524902715392_1.png
1425405459209494535_1.jpg
1379381103836942336_1.png
1361273519573594113_1.png
1310414064380641280_1.png
1257234862689316866_1.jpg
1252068110972026882_1.png
1193676606893518848_1.png
1193665231269986304_1.png
1183518023862247424_1.png
1180998161524908032_1.png
1101859093138948099_1.png
1079512706921639936_1.png
1069388060905791488_1.png
929860005821431808_1.png
917165629613977600_1.png
895804122603020288_1.jpg
892695460153933828_1.png
884197374716821508_1.png
841063459399729152_1.png
818237049136234496_1.png
764098971132317696_1.png
706914185553137664_1.jpg
652075868228067328_1.png
619841635703128064_1.jpg
604626418618658816_1.png
592731606659506177_1.png |
This reverts commit a94f944.
Images from replies no longer appear on the
/media
tab, therefore they don't get downloaded, it can be worked around by using/with_replies
but that downloads way more than necessary even withretweets=false
, also makes it hit the rate limit faster.The text was updated successfully, but these errors were encountered: