Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add manganelo extractor #1415

Merged
merged 1 commit into from
Apr 2, 2021
Merged

Add manganelo extractor #1415

merged 1 commit into from
Apr 2, 2021

Conversation

folliehiyuki
Copy link
Contributor

@folliehiyuki folliehiyuki commented Mar 29, 2021

Closes #676. Based on mangakakalot extractor, since they are similar.
I don't know how to get the hash of content, url, keyword,... for the test.

Help appreciated.

@folliehiyuki folliehiyuki changed the title [WIP] Add manganelo extractor Add manganelo extractor Mar 29, 2021
@folliehiyuki folliehiyuki marked this pull request as ready for review March 29, 2021 21:39
@folliehiyuki folliehiyuki force-pushed the manganelo branch 3 times, most recently from 2acdb47 to 230ffa5 Compare March 30, 2021 08:18
@mikf
Copy link
Owner

mikf commented Apr 1, 2021

Thank you for the contribution.

Do you know what's the deal with manganelo.tv? I searched for manganelo and Google spit out manganelo.tv as the first result. It looks very much like manganelo.com, but its HTML structure is different.

I don't know how to get the hash of content, url, keyword,... for the test.

Hashes should only be used for static results, but https://manganelo.com/manga/gq921227 is still "Ongoing". It'd be better to use pattern and count like in the other test below so tests don't start failing when a new chapter gets added.

To get the hash values, I usually make sure everything works as it should, then run tests with empty url, etc and fill in the results from there: python test_results.py manganelo.

scripts/supportedsites.py Outdated Show resolved Hide resolved
@folliehiyuki
Copy link
Contributor Author

Do you know what's the deal with manganelo.tv?

Sadly I don't.
I think manganelo.com is the more legit one, since lots of search results from mangakakalot.com point to manganelo.com and they use the same domain to host the images.

Hashes should only be used for static results, but https://manganelo.com/manga/gq921227 is still "Ongoing"

The manga is actually finished. I could find other ones that are finished as well but still in "Ongoing" status on manganelo.com

@mikf mikf merged commit e3b9f88 into mikf:master Apr 2, 2021
@folliehiyuki folliehiyuki deleted the manganelo branch April 2, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

possible support for https://manganelo.com
2 participants