Check if file is in archive before trying to build path

[KennethSamael]

Addresses #2461

Just a minor reordering that should ensure no new directories are created for files that are already in archive.

[mikf]

If only it were that easy ...

This obviously works for this particular problem, but it breaks other things down the line. Each line is somewhat dependent on the others happening first and especially set_filename() has way too many side effects.

There already was a similar issue quite some time ago (#722) and I tried putting the directory creation right before opening a file where it should be, but that didn't work and so I settled for what we have right now.

build_path() has to somehow be decoupled from set_filename(), or at least the call to makedirs():

gallery-dl/gallery_dl/path.py

Line 201 in 1171911

self.build_path()

gallery-dl/gallery_dl/path.py

Line 283 in 1171911

os.makedirs(self.realdirectory, exist_ok=True)

[KennethSamael]

I feared that, but I just couldn't imagine a situation where some code needs to run before being allowed to skip the download.

In that case, my second thought is that setting pathfmt._create_directory to false is equivalent to decoupling. As long as there's no situation where a hooked function requires a directory to exist for a file that won't be downloaded, the solution could still be simple.

[mikf]

This has been implemented since v1.22.0 with commit 99cb287.

It caused some problems when using the part-directory functionality, but those could be resolved (#2576). All in all, this caused a lot less issues than expected.