Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oauth] add host config option #2806

Merged
merged 2 commits into from
Aug 14, 2022
Merged

[oauth] add host config option #2806

merged 2 commits into from
Aug 14, 2022

Conversation

martinjuhasz
Copy link
Contributor

There might be situations where you want to bind your oauth web server to something other than localhost.

F.e. if you use gallery-dl in a docker environment and you want to expose the oauth port to its network, there is currently no way as you need to bind the host to 0.0.0.0 to be able to forward ports.

@martinjuhasz
Copy link
Contributor Author

@mikf not sure why tests fail. Does not seem to be related to my change

@mikf
Copy link
Owner

mikf commented Aug 14, 2022

Yeah, those errors are unrelated to your changes.
(they are caused by dd3a6a9, and fixed in c0051d7, which got pushed more than a week later ...)

Thanks for the PR.

@mikf mikf merged commit 9ea521b into mikf:master Aug 14, 2022
@Draic
Copy link

Draic commented Aug 24, 2022

I am facing this problem at the moment but the host option does not seem to work for me. Where in the config must this be added? I tried several ways but the OAuth always tries localhost and gallery-dl isn't listening when I try to manually redirect to the servers IP

@martinjuhasz
Copy link
Contributor Author

hi @Draic , this PR has been merged but there has not been a new release of gallery-dl yet. I guess with the next release you will be able to use this option. Or pull directly from master here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants