Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for aibooru (using danbooru extractor) #3075

Merged
merged 2 commits into from
Oct 19, 2022
Merged

add support for aibooru (using danbooru extractor) #3075

merged 2 commits into from
Oct 19, 2022

Conversation

thatfuckingbird
Copy link
Contributor

Adds support for aibooru.online, a danbooru-based site.

One difference from the main danbooru site is that for whatever reason, aibooru returns relative URLs, e.g.
on danbooru you have in post:
'file_url': 'https://cdn.donmai.us/original/3c/1a/3c1a2a04a6060c497b714b9007a8331f.png'
while on aibooru:
'file_url': '/data/original/0c/54/0c540b58dc26913e77d86e318b0552d4.png'
The added check aims to detect and fix this situation.

thatfuckingbird and others added 2 commits October 18, 2022 21:04
- update supportedsites.md
- add tests
- use slightly faster method to check for relative URLs
@mikf mikf merged commit 062ef23 into mikf:master Oct 19, 2022
@Hrxn Hrxn mentioned this pull request Oct 27, 2022
@Hrxn
Copy link
Contributor

Hrxn commented Jan 8, 2023

Just noticed that AIBooru is not listed with support for Authentication at the Supported Sites, is this simply a missing entry here, or is this not supported by this site?
I mean, based on danbooru.py, AIBooru is listed just like the other instances, and nothing indicates a difference in implementation here?

mikf added a commit that referenced this pull request Jan 8, 2023
@Hrxn
Copy link
Contributor

Hrxn commented Jan 9, 2023

Thanks 😇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants