Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimize _find_most_recently_used_file for exact profile #5538

Merged
merged 1 commit into from
May 2, 2024

Commits on May 2, 2024

  1. optimize _find_most_recently_used_file for exact profile

    When reading cookies from the browser, the user is able to give either just the browser name, or also provide profile/container information.
    
    If an exact profile is provided, there is no need to find the latest profile with `os.walk` which is very expensive.
    
    This change optimizes that case and the performance increase is significant (~8 sec to 0.6 sec).
    
    ```
    $ time gallery-dl --config-ignore -d . -D . --cookies-from-browser FIREFOX https://imgur.com/OO4UNqJ
    [cookies][info] Extracted 16 cookies from Firefox
     ./imgur_OO4UNqJ.jpg
    
    real    0m8.429s
    user    0m0.216s
    sys     0m0.431s
    
    $ time gallery-dl --config-ignore -d . -D . --cookies-from-browser FIREFOX:bgamf5r6.default-release https://imgur.com/OO4UNqJ
    [cookies][info] Extracted 16 cookies from Firefox
     ./imgur_OO4UNqJ.jpg
    
    real    0m0.456s
    user    0m0.183s
    sys     0m0.011s
    
    $ gallery-dl --version
    1.26.9
    ```
    unfo authored and mikf committed May 2, 2024
    Configuration menu
    Copy the full SHA
    06d102f View commit details
    Browse the repository at this point in the history