[furaffinity] Add 'thumbnail' (#1284) and 'folders' properties #5824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retrieve 'thumbnail' and 'folders' properties for each post. 'thumbnail' (mikf#1284): - Preview image used for search results, writing posts, music, etc. - Filename format: <post_id>@600-<directory_containing_full_image>.jpg 'Folders' (related to mikf#1817): - A list of all gallery folders containing this post - Folder name format: [<folder_category> - ]<folder_name> - Only works on new layout; old layout does not show folders, so list will be empty A test is included for each property.
Forgot to remove this from a previous implementation attempt
mikf
reviewed
Jul 11, 2024
Comment on lines
+116
to
+118
| data["folders"] = [rh(folder) for folder in extr( | ||
| '<h3>Listed in Folders</h3>', | ||
| '</section>').split('</a>') if rh(folder) != ''] |
There was a problem hiding this comment.
Suggested change
| data["folders"] = [rh(folder) for folder in extr( | |
| '<h3>Listed in Folders</h3>', | |
| '</section>').split('</a>') if rh(folder) != ''] | |
| data["folders"] = folders = [] | |
| for folder in extr( | |
| "<h3>Listed in Folders</h3>", "</section>").split("</a>"): | |
| folder = rh(folder) | |
| if folder: | |
| folders.append(folder) |
More code, but it calls remove_html() only once.
Walrus operator would be useful here when using a list comprehension, but that's Python 3.8+.
| @@ -132,11 +135,16 @@ def _parse_post(self, post_id): | |||
| data["_description"] = extr( | |||
| '<td valign="top" align="left" width="70%" class="alt1" ' | |||
| 'style="padding:8px">', ' </td>') | |||
| data["folders"] = [] # folders not present in old layout | |||
There was a problem hiding this comment.
Suggested change
| data["folders"] = [] # folders not present in old layout | |
| data["folders"] = () # folders not present in old layout | |
Empty tuple is more lightweight than constructing a new empty list every time.
Comment on lines
+144
to
+147
| data["thumbnail"] = ( | ||
| 'https://t.furaffinity.net/' + | ||
| str(data['id']) + '@600-' + | ||
| data['url'].split('/')[-2] + '.jpg') |
There was a problem hiding this comment.
Suggested change
| data["thumbnail"] = ( | |
| 'https://t.furaffinity.net/' + | |
| str(data['id']) + '@600-' + | |
| data['url'].split('/')[-2] + '.jpg') | |
| data["thumbnail"] = "https://t.furaffinity.net/{}@600-{}.jpg".format( | |
| post_id, path.rsplit("/", 2)[1]) |
A format string is simpler and rsplit is a bit faster here.
We can also reuse some variables instead of accessing data.
mikf
added a commit
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrieve 'thumbnail' and 'folders' properties for each post. A test case is included for each property.
'thumbnail':
'folders':
Users can now use --filter with folder names, providing a workaround for #1817.
In the future, 'thumbnail' could be used to automatically download thumbnails for writing, music, and other non-image posts, which would fully resolve #1284.