[aryion] Add favorite extractor #5870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walkenjoyer
changed the title
walkenjoyer
commented
Jul 20, 2024
| class AryionFavoriteExtractor(AryionExtractor): | ||
| """Extractor for a user's favorites gallery""" | ||
| subcategory = "favorite" | ||
| categorytransfer = True |
There was a problem hiding this comment.
Is this correct here? I copied it from the gallery extractor, but I don't understand what it does.
There was a problem hiding this comment.
This makes it so that child extractors use the same settings as their parent by default (extractor.category-transfer). Not really necessary here I think, but it probably won't hurt to have this enabled just in case.
mikf
added a commit
that referenced
this pull request
Jul 21, 2024
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4511
I tried my best without a lot of python experience, I hope this is good enough to close the issue.
The
pathkeyword won't match the path in the favorite gallery, but the original path in the artists gallery. I'm not sure of what the best solution would be, but I'm not too bothered by it right now