Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[e621] cache pool metadata API calls #6001

Merged
merged 1 commit into from
Aug 13, 2024

Conversation

ClosedPort22
Copy link
Contributor

It's quite common to encounter multiple posts from the same pool when downloading tags from e621. Currently when the pools option is enabled, gallery-dl will make a web request every time it encounters such a post.

This PR reduces the number of API requests (and also makes the download job slightly faster) by memcaching API calls to /pools.json.

mikf added a commit that referenced this pull request Aug 13, 2024
@mikf mikf merged commit 0f0ded5 into mikf:master Aug 13, 2024
9 checks passed
@ClosedPort22 ClosedPort22 deleted the improvement/e621-cache-pool branch August 14, 2024 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants