[flickr] reference the correct function #6077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I honestly couldn't figure out how to name this commit, so I welcome any suggestions. |
|
Thank you very much for catching and even fixing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug introduced in e92a9ae#diff-5741d04464e95eab8716d83190078fd31be0ad91fed8da24cd390b9447239d35R522.
Before the referenced commit, the code read
photo.update(self.api.photos_getAllContexts(self.item_id)). After the commit, the code became the same (see how the EXIF-related code above was updated correctly), referencingself.api, which doesn't exist in this new context, which completely breaks this functionality since that exception will always become a warning, when it really should've been caught while reviewing the changes: