Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bearer auth for bluesky #6455

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

GiovanH
Copy link
Contributor

@GiovanH GiovanH commented Nov 12, 2024

@mikf I'm sure you'll want to reorganize this, but this fixes #6134 and makes bluesky work, instead of not working.

Due to under-the-hood implementation of the requests library, we have to pass the bearer authentication info in the special auth kwarg, or else the basic token from the session will overwrite it.

@mikf
Copy link
Owner

mikf commented Nov 12, 2024

Pretty sure all of this can be accomplished with one line of code:

    self.session.auth = None

@GiovanH
Copy link
Contributor Author

GiovanH commented Nov 12, 2024

I was acting under the assumption that some pre-bearer requests in the session still needed the Basic token. If, as per #6134 (comment), we can remove the basic token entirely, self.session.auth = None would do it. But we need to figure out the basic token thing from #6134 first

mikf added a commit that referenced this pull request Nov 15, 2024
(#6134, #6455)
disable using environment proxies by default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bluesky authentication error: InvalidToken: Unexpected authorization type
2 participants