Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add verify-segment command #151

Merged
merged 1 commit into from
Jun 12, 2023

Conversation

congqixia
Copy link
Collaborator

@congqixia congqixia commented Jun 10, 2023

This PR contains following changes:

  • Add verify-segment command to check storage files matches meta
  • Fix statslog path in segment information
  • Fix GetCollectionByID key usage value bug

/kind improvement

See also #145

Signed-off-by: Congqi Xia <[email protected]>
@sre-ci-robot sre-ci-robot added the kind/improvement Changes related to something improve, likes ut and code refactor label Jun 10, 2023
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiaoew1991
Copy link
Collaborator

/lgtm

@sre-ci-robot sre-ci-robot added the lgtm look good to me label Jun 12, 2023
@sre-ci-robot sre-ci-robot merged commit 8fcf065 into milvus-io:main Jun 12, 2023
@congqixia congqixia deleted the add_verify_segment branch June 16, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed kind/improvement Changes related to something improve, likes ut and code refactor lgtm look good to me size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants